Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gh hover command #945

Merged
merged 2 commits into from
Oct 19, 2016
Merged

add gh hover command #945

merged 2 commits into from
Oct 19, 2016

Conversation

will-wow
Copy link
Contributor

Yay! We love PRs! 🎊

Please include a description of your change and ensure:

  • Commit message has a short title & issue references
  • Each commit does a logical chunk of work.
  • It builds and tests pass (e.g gulp)

More info can be found on our contribution guide.

@johnfn After talking on the Slack channel (as willwow), here's a little PR to add a gh command to bring up the hover text when in normal mode. One thing that's annoying is that it seems that showHover takes focus away from the editor, so you have to press ESC to get back to normal mode (the same thing happens with the default VS Code shortcut). I'd think that ideally any other command would close that hover box, but I'm not sure how I'd set that up.

Thanks!

@johnfn
Copy link
Member

johnfn commented Oct 19, 2016

Very nice! Thanks for the cool new command, @whenther! :)

@johnfn johnfn merged commit ea463a1 into VSCodeVim:master Oct 19, 2016
@will-wow will-wow deleted the hover-shortcut branch October 19, 2016 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants